search

voxpupuli / puppet-squid

Puppet module for configuration of squid caching proxy.
https://forge.puppet.com/puppet/squid
Other
12 stars 54 forks source link

ssl::server_name syntax error #117

Closed DidgeriDude closed 5 years ago

DidgeriDude commented 5 years ago

Not sure if this is an issue with puppet or the module, but I am unable to use 'ssl::server_name' due to a syntax error.

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

squid::acl {'whitelisted_https_sites': type => 'ssl::server_name', entries => $whitelisted_sites, }

Also fails when escaping the characters

squid::acl {'whitelisted_https_sites': type => 'ssl\:\:server_name', entries => $whitelisted_sites, }

What are you seeing

Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Concat::Fragment['squid_acl_allowed_https_websites']: 'order' cannot contain '/', ':', or '\n'. (file: /root/test/modules/concat/manifests/fragment.pp, line: 27, column: 5) (file: /root/test/modules/squid/manifests/acl.pp, line: 15) on node squid

Is there any way to bypass this? I also tried using squid::extra_config_section.

ekohl commented 5 years ago

https://github.com/voxpupuli/puppet-squid/commit/8f8b7e32b5eb8497e0848727b99cb9a4beaaa780#diff-c9e6a3913500ff4c764544544068d6c4 should solve this. It's also supposed to be part of 1.0.0 so it confuses me why this is a problem. Could you confirm that patch is part of the code?

DidgeriDude commented 5 years ago

You are right. I thought the version was 1.0.0. However, I might have not checked. I'm sorry for this. This issue can be closed.