When specifying the extra_config_sections as an array

voxpupuli / puppet-squid

Puppet module for configuration of squid caching proxy.

https://forge.puppet.com/puppet/squid

Other

12 stars 54 forks source link

When specifying the extra_config_sections as an array #45

Closed ralfbosz closed 7 years ago

ralfbosz commented 7 years ago

the entries are set on multiple lines instead of joined on the same line

also fixed an error in the example which was missing some }

traylenator commented 7 years ago

We can't just change the test here in the .robocop.yml , the file is templated in.

ralfbosz commented 7 years ago

I've reversed the .rubocop.yml to the "master-branch" version, but still shows as diff in the PR.

The change was made to make it pass the Travis CI, don't have everything installed on my current machine to do local testing...

Ok removed the .rubcopy.yml from the commit...

ralfbosz commented 7 years ago

it failed at first, seems the docker-image of ubuntu-16.04 requires the installation of "locales", since "locale-gen en_US.UTF-8" is not available otherwise.

fixed it in the PR, now it's all green...

ralfbosz commented 7 years ago

I've updated my PR, only changed what was needed for this function...