search

voxpupuli / puppet-squid

Puppet module for configuration of squid caching proxy.
https://forge.puppet.com/puppet/squid
Other
12 stars 54 forks source link

Add refresh_pattern defined type #57

Closed matonb closed 7 years ago

matonb commented 7 years ago

Adds a defined type for Squid refresh_pattern configuration directive.

matonb commented 7 years ago

@alexjfisher Added Pattern to params to replace the last couple of validate_re calls and updated memory_cache_shared to accept on/off or boolean value.

matonb commented 7 years ago

@alexjfisher I was wondering about that check in the template.

I'll update with .nil and see if it still works as expected.

matonb commented 7 years ago

@alexjfisher Think the tests are Ok: https://github.com/voxpupuli/puppet-squid/blob/3daf11d68e2d8229db95eaeed7c9f8cf4d21d75b/spec/classes/init_spec.rb#L66

https://github.com/voxpupuli/puppet-squid/blob/3daf11d68e2d8229db95eaeed7c9f8cf4d21d75b/spec/classes/init_spec.rb#L88

alexjfisher commented 7 years ago

Merged. Thanks @matonb !