search

voxpupuli / puppet-squid

Puppet module for configuration of squid caching proxy.
https://forge.puppet.com/puppet/squid
Other
12 stars 54 forks source link

Add remaining custom defines #7

Closed jcpunk closed 8 years ago

jcpunk commented 8 years ago

Not too sure why github closed PR#4 or why I can't seem to get it to re-open....

In any case, here is another stab at the remaining custom defines.

jyaworski commented 8 years ago

Tests fail, but it looks good so far.

jcpunk commented 8 years ago

Any ideas how I can fix the test that fails?

jyaworski commented 8 years ago

@jcpunk forget the jruby failures. It looks like adding this changed some default to where a file is no longer in the catalog.

jcpunk commented 8 years ago

I must have looked at that a dozen times and not seen it.

traylenator commented 8 years ago

@jcpunk thanks again, it's all looking good and I have now fixed tests again.

Please rebase, I'll merge and then get a release out - thanks.

Steve.

jcpunk commented 8 years ago

Rebased

jyaworski commented 8 years ago

@jcpunk one rubocop error. rubocop -a should fix it.

jcpunk commented 8 years ago

Done