Closed ralfbosz closed 6 years ago
in doubt about the : which is used in the template, that should not be fixed, only few refresh_patterns use it, gonna change that too... after some testing...
remove the default use of : after the title, this is not default, see examples:
seems I didn't check all the PR's, this is in part: https://github.com/voxpupuli/puppet-squid/pull/65
To be clear someone doing.
squid::refresh_pattern{'ftp':
min => 20,
max => 30,
percent 100,
}
were getting
refresh_pattern ftp: 100 20 30
and now the will get
refresh_pattern ftp 100 20 30
backwards incompatible but the old behaviour was wrong.
Correct, the old behaviour was wrong, see also #65 which also addresses this, but fails in Travis...
For you sample, the person would have to use:
squid::refresh_pattern{'ftp:':
min => 20,
max => 30,
percent => 100,
}
When using a regexp (when case_sensitive is set to false) the -i should be placed BEFORE the $name and not after Also fixed that no space was used between the max and options field, added rspec for options