Please check the following items before submitting a PR -- thank you!
Note that this project is released with a Contributor Code of Conduct.
By participating in this project you agree to abide by its terms.
Contributor Code of Conduct.
[X] There is no existing PR that addresses this problem
[X] Mentioned any existing issues in your commit so they get linked and
closed once this PR gets merged, i.e: Closes #1554 in the body of a commit
[X] Followed the instructions in the Contributing document
[X] Ran the unit/spec tests and ensured they still pass
[X] Added tests to cover the new behaviour
[X] Updated the documentation to match the changes
[X] When possible, add an entry to the CHANGELOG file
[X] Squashed your PR down to a single commit. You may forego this if the PR
tries to address multiple issues. Though we prefer one PR per feature/fix,
sometimes that's not feasible. In that case ensure that a single feature/fix
and associated tests and documentation is bundled up in one commit
Optional, but extra points:
[X] Added tests to ensure the old behaviour cannot accidentally be
reintroduced
No need to continue to mention 0.2.0 and 1.0.0 now that we're on 2.0.0!
Please check the following items before submitting a PR -- thank you!
Note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms. Contributor Code of Conduct.
Closes #1554in the body of a commitOptional, but extra points:
No need to continue to mention 0.2.0 and 1.0.0 now that we're on 2.0.0!