search

voxpupuli / puppet-staging

⛔️ Deprecated in favor of puppet-archive
https://forge.puppet.com/puppet/archive
Apache License 2.0
51 stars 109 forks source link

Use ensure_resource to create staging dir. Fixes #109 #112

Closed shaunrampersad closed 4 years ago

shaunrampersad commented 8 years ago

Fix for #109

dhoppe commented 8 years ago

@alexjfisher It should not be a problem to use ensure_resource instead of if ! defined( ... ). I did a restart of the Travis CI build and everything is green, again.

@shaunrampersad Maybe we should also remove if ! defined( ... ) from init.pp.

alexjfisher commented 8 years ago

@dhoppe I'd prefer we fix the actual bug rather than papering over it. ensure_resources will still create duplicate resource errors if the parameters of each resource don't match. https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/lib/puppet/parser/functions/ensure_resource.rb#L18

I think the tests pass because they aren't thorough enough.

alexjfisher commented 8 years ago

I've added an extra commit to this PR in https://github.com/voxpupuli/puppet-staging/pull/114 The added test shows a duplicate resource error can still occur.

I haven't got time just right now, but I'll work on the actual fix soon.

alexjfisher commented 8 years ago

I've opened https://github.com/voxpupuli/puppet-staging/pull/115

@shaunrampersad If possible, could you let me know if this fixes your issue? (It might not, as your issue seemed to be slightly different from the one I got whilst trying to reproduce).

juniorsysadmin commented 7 years ago

@shaunrampersad ping

vox-pupuli-tasks[bot] commented 4 years ago

Dear @shaunrampersad, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

ekohl commented 4 years ago

This module is deprecated in favor of puppet-archive and as such won't receive any more updates.