Closed FunFR closed 6 years ago
Hi @FunFR, thanks for the PR. Can you please take a look at the used email addr? It isn't associated with your github profile.
Hi @FunFR, is it possible that you review the git history? It looks a bit wrong. If you need help with git, feel free to join our IRC channel #voxpupuli on freenode, we are happy to help out.
Could you rebase this? If needed we can help.
done ... Sorry for the delay :)
No problem, sometimes life distracts you. Thanks for rebasing. Could you address the rubocop failure? Then I can merge it and include it in the release I want to make.
Didn't you just add a second commit that fixed rubocop? I don't see it anymore.
squash with rubocop patch
Awesome, thanks!
@FunFR please check the used email address in the commit, it isn't associated with your github account.
Merging the tar PR also introduced a merge conflict.
Looks like that didn't work. Did you pull in the latest master?
Thanks for the rebase @FunFR !
rebased it again