search

voxpupuli / puppet-staging

⛔️ Deprecated in favor of puppet-archive
https://forge.puppet.com/puppet/archive
Apache License 2.0
51 stars 109 forks source link

add support for 7zip #132

Closed FunFR closed 6 years ago

FunFR commented 7 years ago
bastelfreak commented 7 years ago

Hi @FunFR, thanks for the PR. Can you please take a look at the used email addr? It isn't associated with your github profile.

bastelfreak commented 7 years ago

Hi @FunFR, is it possible that you review the git history? It looks a bit wrong. If you need help with git, feel free to join our IRC channel #voxpupuli on freenode, we are happy to help out.

ekohl commented 6 years ago

Could you rebase this? If needed we can help.

FunFR commented 6 years ago

done ... Sorry for the delay :)

ekohl commented 6 years ago

No problem, sometimes life distracts you. Thanks for rebasing. Could you address the rubocop failure? Then I can merge it and include it in the release I want to make.

ekohl commented 6 years ago

Didn't you just add a second commit that fixed rubocop? I don't see it anymore.

FunFR commented 6 years ago

squash with rubocop patch

ekohl commented 6 years ago

Awesome, thanks!

bastelfreak commented 6 years ago

@FunFR please check the used email address in the commit, it isn't associated with your github account.

ekohl commented 6 years ago

Merging the tar PR also introduced a merge conflict.

ekohl commented 6 years ago

Looks like that didn't work. Did you pull in the latest master?

bastelfreak commented 6 years ago

Thanks for the rebase @FunFR !

bastelfreak commented 6 years ago

rebased it again