search

voxpupuli / puppet-staging

⛔️ Deprecated in favor of puppet-archive
https://forge.puppet.com/puppet/archive
Apache License 2.0
51 stars 109 forks source link

Use $target_file in *_get variables, not $name #24

Closed reidmv closed 10 years ago

reidmv commented 10 years ago

When a user specifies the $target parameter in a staging::file defined type, the intention is to fetch the file from $source and place it at $target. When $name is used in the $http_get variants, the retrieved file won't actually be placed at the $target location. This commit makes it so that curl and wget will always place the retrieved file in the $target_file location. This should not impact the behavior when a user doesn't specify $target, but should fix the unexpected behavior when they do.

reidmv commented 10 years ago

I see that this would require changes to the spec tests. I'll try and look at that later.

reidmv commented 10 years ago

@nanliu, the Travis CI build seems to have failed due to an external error (something about couldn't download a gem) for 2 of 3 ruby versions. Can you kick off a rebuild? I think the PR has working tests so a rebuild will likely result in a CI pass.

nanliu commented 10 years ago

Weird retry resulted in same error, may need to take a closer look.

reidmv commented 10 years ago

Seems to be ok now.