workaround for failed "get" commands

voxpupuli / puppet-staging

⛔️ Deprecated in favor of puppet-archive

https://forge.puppet.com/puppet/archive

Apache License 2.0

51 stars 109 forks source link

workaround for failed "get" commands #42

Closed vchepkov closed 9 years ago

vchepkov commented 10 years ago

Sometimes commands like wget fail to download a file and create a file with 0 length instead The next time agent runs it will see the file and won't retry to download it again. It's hard to imagine someone would ever want to stage an empty file, so this workaround should work in general cases

nanliu commented 10 years ago

This is not portable for users on Windows. I would checkout the http://www.github.com/nanliu/puppet-archive module. I'm hoping to provide a wrapper around staging to allow people to migrate to the types/provider resources since it's much easier to solve these issues.

ffrank commented 9 years ago

Also, Puppet is getting HTTP support in the file type soon-ish.

All that being said, I'd be happy to take this in, provided

the unless clause is limited to non-Windows platforms
there is a test for it

@vchepkov are you still interested in seeing this upstream?

vchepkov commented 9 years ago

I am using it from my fork. If this module obsolete by puppet-archive or it's still going to be supported?

vchepkov commented 9 years ago

I don't have any experience with writing tests or puppet on Windows. This still and issue though, so I will open one instead.