voxpupuli / puppet-staging

⛔️ Deprecated in favor of puppet-archive
https://forge.puppet.com/puppet/archive
Apache License 2.0
51 stars 109 forks source link

unzip should use -o -f always or optionally #81

Closed tzz closed 9 years ago

tzz commented 9 years ago

Currently, if a file exists, unzip will prompt, which is usually the wrong thing. So the -o -f flags should be passed, optionally controlled with $overwrite and $freshen or whatever.

nanliu commented 9 years ago

Let us know if #83 is sufficient.

tzz commented 9 years ago

I think the default should be -o -f so unzip doesn't try to prompt, but #83 is enough for my needs. Please close if you don't plan to change the default. Thanks!