search

voxpupuli / puppet-staging

⛔️ Deprecated in favor of puppet-archive
https://forge.puppet.com/puppet/archive
Apache License 2.0
51 stars 109 forks source link

Set staging::extract's timeout in staging::deploy. #9

Closed ojacobson closed 10 years ago

ojacobson commented 11 years ago

I've opted to have extract's timeout default to the same value as file's, which changes the theoretical maximum execution time from $timeout + 5 minutes (exec's default timeout) to 2 * $timeout. To give users more control, there's a new, optional $extract_timeout parameter that affects only the extract stage.

I've also added the corresponding timeout parameter to staging::extract.

ojacobson commented 11 years ago

My motivation for this is a multi-gigabyte archive (the Android SDK, with all the platform parts pre-installed) that takes longer than 5 minutes to unpack. Puppet's default exec timeout is 300 seconds...

nanliu commented 10 years ago

After consideration, will only keep a single timeout configuration for the module.