search

voxpupuli / puppet-system

Manage Linux system resources and services from hiera configuration
https://forge.puppet.com/puppet/system
Apache License 2.0
63 stars 47 forks source link

replace hiera_hash by lookup function #66

Closed florianfa closed 1 year ago

florianfa commented 5 years ago

Pull Request (PR) description

Replace hiera_hash by lookup function

This Pull Request (PR) fixes the following issues

Fixes #58

bastelfreak commented 5 years ago

Hii @florianfa, thanks for the PR. Can you please have a look at the used email address in the commits? It isn't associated with your github account.

florianfa commented 5 years ago

Hello Bastelfreak,

I've reverted the version number and added a second email address. Florian

florianfa commented 5 years ago

I'm not quite sure (I thought of this too) if it's actually easier implementing APL because CLASS_NAME::PARAMETER NAME . From my point of view it needs more refactoring. Have you any suggestions concerning APL? Regards Florian

ekohl commented 5 years ago

All classes already have a $config parameter (or similar). Those can be set via Hiera and the additional lookup is redundant.

vox-pupuli-tasks[bot] commented 4 years ago

Dear @florianfa, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

bastelfreak commented 1 year ago

Hi, based on a discussion in https://groups.io/g/voxpupuli/message/449 we decided to archive this repository. I'm going to close all issues and PRs. If you're interested in maintaining the module, please respond to our mailinglist.