search

voxpupuli / puppet-system

Manage Linux system resources and services from hiera configuration
https://forge.puppet.com/puppet/system
Apache License 2.0
63 stars 47 forks source link

drop ntp support #67

Closed florianfa closed 1 year ago

florianfa commented 5 years ago

Pull Request (PR) description

Drop ntp support

This Pull Request (PR) fixes the following issues

Fixes #56

vox-pupuli-tasks[bot] commented 2 years ago

Dear @florianfa, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

otheus commented 2 years ago

I would reject this MR based on logistics alone. It should be up to the user whether or not to use another module to manage NTP, not us. If one particular user has a problem, and they're not willing to hack the module themselves, then we should fix the problem, not throw away the existing solution. (This is a general rule, when I say "we" I'm not speaking merely of this project's developers).

That's why I believe that @bastelfreak's comment (https://github.com/voxpupuli/puppet-system/issues/56#issuecomment-421567587) says to replace the existing NTP implementation with a different one, not remove the existing implementation and interface. @dhoppe Please reject this merge.

bastelfreak commented 1 year ago

Hi, based on a discussion in https://groups.io/g/voxpupuli/message/449 we decided to archive this repository. I'm going to close all issues and PRs. If you're interested in maintaining the module, please respond to our mailinglist.