voxpupuli / puppet-systemd

Puppet module to manage systemd
https://forge.puppet.com/puppet/systemd
Apache License 2.0
52 stars 142 forks source link

New parameters to manage systemd-nspawn #444

Closed traylenator closed 3 months ago

traylenator commented 3 months ago

Pull Request (PR) description

New parameters systemd::manage_nspawn defaulting to false, if true it will ensure that the machinectl and systemd-nspawn commands are available.

When true the systemd_internal_services fact will be populated.

facter -p systemd_internal_services
{
  systemd-nspawn@.service => "disabled",
}
traylenator commented 3 months ago

I wonder if it makes sense to implement a generic RedHat-family.yaml and then a data/RedHat-family-7.yaml with

systemd::nspawn_package: %

Yeah. I'll do that, am a big fan of making the future default.

traylenator commented 3 months ago

I wonder if it makes sense to implement a generic RedHat-family.yaml and then a data/RedHat-family-7.yaml with

systemd::nspawn_package: %

% ? I've always used ~ for undef.

ekohl commented 3 months ago

Sorry, I meant ~ but that's what you get for quickly trying to review something.