Closed danielsreichenbach closed 4 years ago
vox-pupuli-tasks[bot]
commented
4 years ago Dear @danielsreichenbach, thanks for the PR!
This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Woth-Ursula
commented
4 years ago This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
The CI failures contain errors/warning like below. They were already in the module and do not belong to our changes. Is it ok when I fix such things?
manifests/install.pp:76:manifest_whitespace_closing_brace_before:ERROR:there should be a single space or newline before a closing brace manifests/install.pp:62:manifest_whitespace_two_empty_lines:ERROR:there should be no two consecutive empty lines manifests/install.pp:39:strict_indent:WARNING:indent should be 10 chars and is 12
bastelfreak
commented
4 years ago hi, sorry for the trouble! I fixed those in https://github.com/voxpupuli/puppet-telegraf/pull/151. can you please rebase?
bastelfreak
commented
4 years ago thanks for the updates. Can you add unit tests to ensure the ordering is now correct?
Woth-Ursula
commented
4 years ago Added some specs. Hope they meet your expectations.
bastelfreak
commented
4 years ago thanks for the work!
Pull Request (PR) description
This changes the repository installation to retain the relation between package repository and package even when the repository is not managed by the module.
This Pull Request (PR) fixes the following issues
This fixes use issues caused by missing dependency when e.g. using other modules to handle InfluxData packages like InfluxDB, Chronograf or Kapacitor and Telegraf is not managing the repository itself.