search

voxpupuli / puppet-telegraf

A Puppet module for installing and configuring InfluxData's Telegraf
https://forge.puppet.com/puppet/telegraf
GNU General Public License v3.0
24 stars 98 forks source link

Relax version constraint for puppetlabs-stdlib #220

Closed mj closed 12 months ago

mj commented 1 year ago

Pull Request (PR) description

This PR relaxes the version constraint for puppetlabs-stdlib to >= 8.1.0 so that it is easier to use the module in Puppet environments with modules that explicitly depend on < 9.

This Pull Request (PR) fixes the following issues

Fixes #219

smortex commented 1 year ago

The dependency was bumped in #207 where we use stdlib::to_toml. stdlib::to_toml replace to_toml available in older versions of stdlib, but this old function is deprecated and raise an error when called on Puppet 8 with the default configuration.

I would recommend sticking to an older version of the module it you are blocked by some modules that do not support Puppet 8 / recent stdlib yet, and rather push these modules to be updated.

bastelfreak commented 12 months ago

IMO the correct way is to update older modules to support newer stdlib version instead. And as @smortex said, we cannot downgrade.