search

voxpupuli / puppet-unbound

Puppet module for deploying the swiss-army of DNS, Unbound
https://forge.puppet.com/puppet/unbound
Apache License 2.0
28 stars 71 forks source link

stub: add support for stub-first stub zone option #322

Closed irregulator closed 12 months ago

irregulator commented 12 months ago

Pull Request (PR) description

Add support for stub-first stub zone option, which defaults to false. It allows queries to be attempted again without the stub clause if they failed with stub.

This Pull Request (PR) fixes the following issues

irregulator commented 12 months ago

I'm not quite sure why static validation fails, but I'll be happy to get feedback on how to fix it.

kenyon commented 12 months ago

It's saying that REFERENCE.md is outdated: https://github.com/voxpupuli/puppet-unbound/pull/322/checks#step:5:204

All of the documentation comments need to be updated to the new format: https://www.puppet.com/docs/puppet/8/puppet_strings.html

irregulator commented 12 months ago

It's saying that REFERENCE.md is outdated: https://github.com/voxpupuli/puppet-unbound/pull/322/checks#step:5:204

All of the documentation comments need to be updated to the new format: https://www.puppet.com/docs/puppet/8/puppet_strings.html

Thanks @kenyon .

irregulator commented 12 months ago

Okay I got static validations to pass. Now it's Centos 8 that's failing: https://github.com/voxpupuli/puppet-unbound/actions/runs/6275268917/job/17042416969

from the output am not sure if the timeout means that the acceptance command was never executed in the container or it was actually executed and failed.

Any hints?

kenyon commented 12 months ago

That looks like a temporary network error. I just reran the job.

irregulator commented 11 months ago

Thanks!