voxpupuli / puppet-unbound

Puppet module for deploying the swiss-army of DNS, Unbound
https://forge.puppet.com/puppet/unbound
Apache License 2.0
28 stars 71 forks source link

$conf_d and $unbound_conf_d are not documented and unclear how they differ beyond their location #342

Open arusso opened 6 months ago

arusso commented 6 months ago

I'm trying to understand the difference between the undocumented $conf_d and $unbound_conf_d parameters of the unbound class. Neither seems to be used anywhere outside of ensuring directory ownership (but not included in the configuration by default), and in the case of the $unbound_conf_d directory, you can also ensure the directory is purged of unmanaged configurations.

Can we get these parameters documented based on the intended usage?

Valantin commented 6 months ago

I'm not sure, but a possible explaination was: unbound_conf_d is the default directory for many OS packages with precondigured configuration, the module purge the content. conf_d I assume is a directory with not managed configuration we want to use, the module create it by default but not include it in the configuration

b4ldr commented 2 months ago

Looking through the history i think theses parameters probably point to the same thing but are perhaps different on different distros. The commit that introduced the conf_d directory mentions SuSE support. and the PR (#225) that added $unbound_conf_d mentions Debian so we can probablly merge theses two parameters but would need to know what the defaults are for each supported distro