search

voxpupuli / puppet-virtualbox

A Puppet module to install and manage VirtualBox
https://forge.puppet.com/puppet/virtualbox
Apache License 2.0
5 stars 30 forks source link

Drop support for camptocamp archive provider #115

Closed ekohl closed 3 years ago

ekohl commented 4 years ago

This module has been archived and was already deprecated. Dropping this simplifies the module.

ekohl commented 4 years ago

I haven't tested this myself, relying on tests. My goal is to drop as much as possible from .sync.yml and modulesync configs.

I didn't update the HTML docs directory since I couldn't generate it. I'm wondering if we should keep this or stick to REFERENCE.md.

Dan33l commented 4 years ago

I haven't tested this myself, relying on tests. My goal is to drop as much as possible from .sync.yml and modulesync configs.

I didn't update the HTML docs directory since I couldn't generate it. I'm wondering if we should keep this or stick to REFERENCE.md.

Have only one format avoids that one of them is not up to date, since files are not automatically generated. And REFERENCE.md is the current standard way that users of module expect.

ekohl commented 4 years ago

https://github.com/voxpupuli/puppet-virtualbox/pull/116 does that.

vox-pupuli-tasks[bot] commented 4 years ago

Dear @ekohl, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @ekohl, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

ekohl commented 4 years ago

Rebased with some more things I missed (README and acceptance).

vox-pupuli-tasks[bot] commented 4 years ago

Dear @ekohl, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks