Add node architecture to the apt repository

voxpupuli / puppet-virtualbox

A Puppet module to install and manage VirtualBox

https://forge.puppet.com/puppet/virtualbox

Apache License 2.0

5 stars 30 forks source link

Add node architecture to the apt repository #81

Closed meskaya closed 5 years ago

meskaya commented 5 years ago

Pull Request (PR) description

Add architecture of node in apt repository to remove a warning message on Ubuntu 18.04.

This Pull Request (PR) fixes the following issues

Fixes #80

meskaya commented 5 years ago

Hey @Dan33l, I did the changes you requested. I hope this is fine :) Cheers

Dan33l commented 5 years ago

LGTM. Can you squash ?

meskaya commented 5 years ago

Sorry @Dan33l :) Am I supposed to be able to do it ? I don’t see where is the merge squash button.

Dan33l commented 5 years ago

Yes you can. Because you are a powerful git user :1st_place_medal: For the next PR you can read [1] section Squashing Commits. Or you can try it for this PR.

[1] https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

meskaya commented 5 years ago

I think I did the squash :)

Dan33l commented 5 years ago

Hi @meskaya . In fact you did a merge. But no problem. I will do it. And so i will be commiter and you will be author.