search

voxpupuli / puppet-wget

A puppet recipe for wget, a useful tool to download arbitary files from the web
Apache License 2.0
41 stars 114 forks source link

Add support for CentOS 8, Debian 10 #115

Closed dhoppe closed 3 years ago

dhoppe commented 4 years ago

The acceptance tests need to be refactored, because they are written for Vagrant.

ekohl commented 4 years ago

You can also ensure the user before hand: https://github.com/voxpupuli/puppet-wget/blob/f286e42ab4f5c40770706d9bb1e654b5236b74f5/spec/acceptance/wget_system_spec.rb#L31-L33

That part runs as root and can create the user if needed. Should be the easiest fix.

dhoppe commented 4 years ago

This module is broken in so many ways and I do not know, why it has not been archived in favour of puppet/archive.

Even if I remove the $strict variables, the acceptance tests will fail, because the user Vagrant does not have sudo permissions to install wget, if necessary. For example at CentOS hosts.

Dan33l commented 4 years ago

why we consume energy to maintain a deprecated module ?

Dan33l commented 4 years ago

IMO we should set this module in archive mode.

alexjfisher commented 4 years ago

IMO we should set this module in archive mode.

It's a dependency of some of our other modules though??? Fix up those first?

alexjfisher commented 4 years ago

IMO we should set this module in archive mode.

It's a dependency of some of our other modules though??? Fix up those first?

Maybe not ours... I have puppet/wget in my Puppetfile because I used a nexus module. But maybe we should adopt that? https://github.com/hubspotdevops/puppet-nexus/issues/116#issuecomment-604409122

ekohl commented 3 years ago

Going to close this since it's deprecated. See https://github.com/voxpupuli/puppet-wget/issues/119.