Add md5sum check - Githubissues

voxpupuli / puppet-wget

A puppet recipe for wget, a useful tool to download arbitary files from the web

Apache License 2.0

41 stars 114 forks source link

Closed squiddle closed 9 years ago

squiddle commented 9 years ago

carlossg commented 9 years ago

I've added some comments. It'd be good to

add unit and system tests
squash the commits into 2: one for implementing retries and another for the sourceHash
add docs

I would implement the hash change into the same definition instead of creating a new one

squiddle commented 9 years ago

i added unit and system tests
i removed the retries change, as i do not need it, it was just part of the original pull request
added additional documentation for $source_hash
the removal of $destination if $source_hash does not match is now always done, i could not think of a reason why puppet should keep a file, where it knows it is not what is intended.
first time i used rebase and push --force for already published changes, feels exciting :) i hope this is correct now

squiddle commented 9 years ago

i also fixed the $command issue you mentioned
and i changed the removal operation to use test; feels better than a forced rm