search

voxpupuli / puppet-wget

A puppet recipe for wget, a useful tool to download arbitary files from the web
Apache License 2.0
40 stars 114 forks source link

Warning: Unknown variable #86

Open rgarrigue opened 7 years ago

rgarrigue commented 7 years ago

Hello

Using latest 1.7.3 version of the module with puppet 4.10.4, I've those warning

==> test.vagrant.local: Warning: Unknown variable: '::http_proxy'. at /etc/puppetlabs/code/environments/production/modules/wget/manifests/fetch.pp:60:19
==> test.vagrant.local: Warning: Unknown variable: '::https_proxy'. at /etc/puppetlabs/code/environments/production/modules/wget/manifests/fetch.pp:65:20
==> test.vagrant.local: Warning: Unknown variable: 'schedule'. at /etc/puppetlabs/code/environments/production/modules/wget/manifests/fetch.pp:184:20
==> test.vagrant.local: Warning: Unknown variable: '::http_proxy'. at /etc/puppetlabs/code/environments/production/modules/wget/manifests/fetch.pp:60:19
==> test.vagrant.local: Warning: Unknown variable: '::https_proxy'. at /etc/puppetlabs/code/environments/production/modules/wget/manifests/fetch.pp:65:20
==> test.vagrant.local: Warning: Unknown variable: 'schedule'. at /etc/puppetlabs/code/environments/production/modules/wget/manifests/fetch.pp:184:20
==> test.vagrant.local: Warning: Unknown variable: '::http_proxy'. at /etc/puppetlabs/code/environments/production/modules/wget/manifests/fetch.pp:60:19
==> test.vagrant.local: Warning: Unknown variable: '::https_proxy'. at /etc/puppetlabs/code/environments/production/modules/wget/manifests/fetch.pp:65:20
==> test.vagrant.local: Warning: Unknown variable: 'schedule'. at /etc/puppetlabs/code/environments/production/modules/wget/manifests/fetch.pp:184:20

Best regards,

TJM commented 6 years ago

It looks to me like we need to remove the "$strict" restriction. There is no reason to try to set that if it is not defined, $strict or not.

Example: https://github.com/voxpupuli/puppet-wget/blob/v1.7.3/manifests/fetch.pp#L57-L66

~tommy