search

voxpupuli / puppet-windowsfeature

Library that uses ServerAdministration api that comes with Windows Server 2008 and Windows Server 2012 to add / remove windows features
https://forge.puppet.com/puppet/windowsfeature
MIT License
30 stars 49 forks source link

replaced execs with powershell provider #10

Closed shoekstra closed 10 years ago

shoekstra commented 10 years ago

Exec has been updated to use the powershell provider.

stack72 commented 10 years ago

Hi @shoekstra,

Thanks so much for the PR. This is really good. The build doesnt work on travis though. I suspect that you haven't updated the associated specs.

As you can https://github.com/opentable/puppet-windowsfeature/blob/master/spec/defines/windowsfeature_spec.rb, the specs include the powershell params that you stripped out

IF you update the specs, then I will have no hesitation in merging this PR

Thanks

Paul

shoekstra commented 10 years ago

Whoops.. :) Give it a whirl now.

Stephen

stack72 commented 10 years ago

@shoekstra FYI, the only change I had to make before merging this was to update this line in the .fixtures file:

stdlib: git://github.com/joshcooper/puppetlabs-powershell.git

powershell: git://github.com/joshcooper/puppetlabs-powershell.git

Your powershell module was being referenced as stdlib thus all the tests were failing.

stack72 commented 10 years ago

btw, thanks so much for the PR. Very useful addition indeed

shoekstra commented 10 years ago

Ah right. Sorry about that - missed that one. No problem - great module.