search

voxpupuli / puppet-windowsfeature

Library that uses ServerAdministration api that comes with Windows Server 2008 and Windows Server 2012 to add / remove windows features
https://forge.puppet.com/puppet/windowsfeature
MIT License
30 stars 50 forks source link

Support for source parameter #18

Closed alex-hempel closed 10 years ago

alex-hempel commented 10 years ago

Under Windows 2012 R2 (and depending on the way it's installed, also under standard 2012) not all Windows features will install natively. Some of them require an additional install source as a parameter, e.g. from a disk drive that an ISO is mounted to. The powershell commands support the source parameter. Would it be possible to add support for that to this module?

JasonCrease commented 10 years ago

+1 I have the same problem

alex-hempel commented 10 years ago

I have experimented a bit and have come up with a code alteration that makes this work. It will most likely require some more testing, and I am absolutely new to writing puppet modules, but if you'd like to take a look at what I've done, please let me know. Might save you a bit of work.

JasonCrease commented 10 years ago

Yes, I would like to see it please. I've tried invoking dism directly as an Exec, but this is a bit flaky.

alex-hempel commented 10 years ago

Hi Jason,

I've made a fork of this project and included my code changes. Feel free to peruse it, but it is probably not 100% stable as yet. I've only had one scenario in which I have used it, and it has worked fine so far.

liamjbennett commented 10 years ago

I need to test this with beaker before it makes it into next main release but I have merged it into master as there appears to be a clear usecase