search

voxpupuli / puppet-windowsfeature

Library that uses ServerAdministration api that comes with Windows Server 2008 and Windows Server 2012 to add / remove windows features
https://forge.puppet.com/puppet/windowsfeature
MIT License
30 stars 49 forks source link

Does not work on Windows 2008 #39

Closed vincent-aguillaume closed 7 years ago

vincent-aguillaume commented 9 years ago

Remove Windows 2008 support from the README / Limitations.

petems commented 8 years ago

@vincent-aguillaume I'm not super experienced but this works on my Vagrant 2008 box, what error are you seeing?

vincent-aguillaume commented 8 years ago

I believe Get-WindowsFeature only works on Windows Server 2008 R2 onwards. I remember having to add another installation method for Windows 2008 (non-R2) when using this module.

NetworkBytes commented 8 years ago

I see the point, it says it supports Windows 2008 (non R2), Windows 2008 (non R2) doesn't have a PowerShell interface to install windows features

I whipped up support for Windows 2008 non R2 @ https://github.com/NetworkBytes/puppet-windowsfeature hasn't been properly tested yet, will PR once Ive had the time to test it out

maxgaulhofer commented 8 years ago

I think this issue can be closed, as the new windowsfeature uses convert-to-xml, instead of json

TraGicCode commented 7 years ago

This is an old issue but going to verify this now.

TraGicCode commented 7 years ago

Yes this indeed doesn't work on Windows 2008 non-r2 currently. As @vincent-aguillaume stated, get-windowsfeature doesn't even exist.

@ghost Not sure if you're still alive since this is so old but your PR is way outdated and since then this module has been converted to using custom types and providers. I will mark this as something that could be added in the future. For now i'm going to update the metadata.json for this project.