search

voxpupuli / puppet-windowsfeature

Library that uses ServerAdministration api that comes with Windows Server 2008 and Windows Server 2012 to add / remove windows features
https://forge.puppet.com/puppet/windowsfeature
MIT License
30 stars 49 forks source link

Refactor into type and provider #43

Closed petems closed 8 years ago

petems commented 8 years ago

Looks like @matthewrstone has done a lot of work on this already :smile:

https://github.com/matthewrstone/puppet-windowsfeature/tree/33-create_type_and_provider

Would also fix the performance issues with an array of features (#53)

matthewrstone commented 8 years ago

I'd be happy to hack away at this some more if additional functionality is required...I just need some guidance for writing the tests.

petems commented 8 years ago

@matthewrstone Awesome, I can help with that, I've done a few tests for my swap_file type and provider:

https://github.com/petems/puppet-swap_file/blob/type_provider_refactor/spec/unit/puppet/provider/swap_file/linux_spec.rb

petems commented 8 years ago

@matthewrstone did some quick work with some basic boilerplate for type and provider unit tests:

https://github.com/puppet-community/puppet-windowsfeature/tree/type_provider_refactor

Thoughts?

petems commented 8 years ago

Closed by #47