search

voxpupuli / puppet-windowsfeature

Library that uses ServerAdministration api that comes with Windows Server 2008 and Windows Server 2012 to add / remove windows features
https://forge.puppet.com/puppet/windowsfeature
MIT License
30 stars 50 forks source link

Default `ensure` to `present` #64

Closed alexjfisher closed 7 years ago

alexjfisher commented 7 years ago

Fixes #63

petems commented 7 years ago

Huh, I thought this was already in the code!

Will merge on green 👍

petems commented 7 years ago

@alexjfisher Got some rubocop failures:

Offenses:
spec/acceptance/windowsfeature_spec.rb:18:10: C: RSpec/ImplicitExpect: Prefer is_expected.to over should. 
    it { should be_installed.by('powershell') }
         ^^^^^^
spec/unit/puppet/type/windowsfeature/windowsfeature_spec.rb:20:7: C: RSpec/ExampleWording: Do not use should when describing your tests. 
  it 'should default to ensure => present' do
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
petems commented 7 years ago

Spectrum is green! 👍