search

voxpupuli / puppet-windowsfeature

Library that uses ServerAdministration api that comes with Windows Server 2008 and Windows Server 2012 to add / remove windows features
https://forge.puppet.com/puppet/windowsfeature
MIT License
30 stars 50 forks source link

Fixed source parameter in provider create #81

Closed cargiris closed 7 years ago

cargiris commented 7 years ago

https://github.com/voxpupuli/puppet-windowsfeature/issues/80

bbriggs commented 7 years ago

Thanks for the PR, @Spartanaco! Since you mentioned extending the patch with tests in #80, would you mind add those to this as well? You'd be the perfect person to do so.

bbriggs commented 7 years ago

Other than that, @bastelfreak and I both think it looks fine.

cargiris commented 7 years ago

So I made a first attempt at adding some new unit tests for these parameters, I am new to this so I am not sure if it is correct, but it passed the automated testing through Travis-CI I have setup on my fork.

Thanks @bbriggs and @bastelfreak ! :smile:

bastelfreak commented 7 years ago

thanks!

stealthybox commented 7 years ago

I believe #81 closes this issue. It's merged pending 2.1.1 release.