fabiosurrage
commented
7 years ago USING: Windows 2008 R2 Puppet 4.10 Puppet Server 2.1.2 (on CentOS 7) Ruby 2.1.9 (on Windows)
I and my job mate have the same problem and we change the ruby code default.rb to fix that issue:
Original Code:
# if win2008 import ServerManager module
result = if win2008 == true
ps('Import-Module ServerManager; Get-WindowsFeature | ConvertTo-XML -As String -Depth 4 -NoTypeInformation')
else
ps('Get-WindowsFeature | ConvertTo-XML -As String -Depth 4 -NoTypeInformation')
end
# create the XML document and parse the objects
xml = Document.new resultChanged code:
# if win2008 import ServerManager module
result = if win2008 == true
ps('Import-Module ServerManager; Get-WindowsFeature | ConvertTo-XML -As String -Depth 4 -NoTypeInformation > C:/ProgramData/PuppetLabs/puppet/cache/lib/puppet/provider/windowsfeature/result.xml')
else
ps('Get-WindowsFeature | ConvertTo-XML -As String -Depth 4 -NoTypeInformation > C:/ProgramData/PuppetLabs/puppet/cache/lib/puppet/provider/windowsfeature/result.xml')
end
file = File.new "C:/ProgramData/PuppetLabs/puppet/cache/lib/puppet/provider/windowsfeature/result.xml"
# create the XML document and parse the objects
xml = Document.new filePs.: We dont know much of ruby, but we think when powershell gives the result to the string, it makes something odd... Using file, we preserve the output xml; You can put the file result.xml in another place
jarretlavallee
Affected Puppet, Ruby, OS and module versions/distributions
How to reproduce (e.g Puppet code you use)
windowsfeature { 'Backup-Features': ensure => present, installsubfeatures => true, }
OR
windowsfeature { 'Backup-Tools': ensure => present, }
What are you seeing
The error I receive is
Error: Failed to apply catalog: malformed XML: missing tag start Line: 4894 Position: 197033 Last 80 unconsumed characters: < /Property>3 <Property Name="Depends
O
I suppose the error is related just to the features shown. I also use the module to install the SNMP feature and the Telnet client feature without problems.
What behaviour did you expect instead
Output log
Debug: Prefetching default resources for windowsfeature Debug: Executing: 'C:\Windows\system32\WindowsPowershell\v1.0\powershell.exe Imp ort-Module ServerManager; Get-WindowsFeature | ConvertTo-XML -As String -Depth 4 -NoTypeInformation' Debug: Storing state Debug: Stored state in 0.31 seconds Error: Failed to apply catalog: malformed XML: missing tag start Line: 4894 Position: 197033 Last 80 unconsumed characters: < /Property>3 <Property Name="Depends
O
Debug: Dynamically-bound server lookup failed, falling back to report_server set
ting
Debug: Dynamically-bound port lookup failed; falling back to report_port setting
Any additional information you'd like to impart