search

voxpupuli / puppet-windowsfeature

Library that uses ServerAdministration api that comes with Windows Server 2008 and Windows Server 2012 to add / remove windows features
https://forge.puppet.com/puppet/windowsfeature
MIT License
30 stars 50 forks source link

Fix Issue #86 #87

Closed fabiosurrage closed 6 years ago

fabiosurrage commented 7 years ago

USING: Windows 2008 R2 Puppet 4.10 Puppet Server 2.1.2 (on CentOS 7) Ruby 2.1.9 (on Windows) I and my job mate have the same problem and we change the ruby code default.rb to fix issue #86 We think when powershell give the result to the string, it makes something odd... Using file, we preserve the output xml; You can put the file result.xml in another place

wyardley commented 7 years ago

@fabiosurrage Thanks for the contribution! The automated tests will need to be updated to mock in the updated commands, and rubocop warnings will need to be resolved. Also, it needs to be rebased due to some recent changes. Perhaps @TraGicCode can help and / or rework this? You can also come to #voxpupuli on IRC or Puppet Slack Community if you need more help with the tests.

TraGicCode commented 7 years ago

@fabiosurrage , can you try the latest release on the forge, 3.0.0, and cofirm if this issue still exists?

TraGicCode commented 6 years ago

Verified this is no longer an issue. Looks like it was fixed in #88