search

voxpupuli / puppet-windowsfeature

Library that uses ServerAdministration api that comes with Windows Server 2008 and Windows Server 2012 to add / remove windows features
https://forge.puppet.com/puppet/windowsfeature
MIT License
30 stars 50 forks source link

Cutting a new Release #90

Closed TraGicCode closed 7 years ago

TraGicCode commented 7 years ago

Hey guys. Working on cutting a first release. Need a little help. Here is the process i have taken thus far.

1.) fork this repo 2.) Create branch called release_prep 3.) Perform a modulesync to get it up-to-date and in the process i had to fix the rubocop issues 4.) Run the changelog generator and begin fixing associating the correct labels to the issues and running the changelog generator on issue issue i added a label to.

My first question is:

In the autogenerated changelog there are 2 issues that refer to the same bug along with a PR that is used to resolve the bug.

Issue - Source parameter doesn't work #80 Issue - Updated source parameter in provider create #81 (cargiris) MergedPR - (GH-85) Fix typo in provider for source parameter #85 (glennsarti)

How is this expected to look in the generated changelog and/or what do i need to do to fix this?

wyardley commented 7 years ago

@TraGicCode Do you want to prep a new release PR once modulesync is merged?

TraGicCode commented 7 years ago

@wyardley heading out for the weekend but I'll force push a new branch to prep the release. Let me handle this one so I have experience and guidance