Replace validate deprecated functions with data types

f1ngerscr0ssed commented 6 years ago

Pull Request (PR) description

validate_* function from the puppetlabs/stdlib are deprecated and should be replaced by a call to validate_legacy or using data types.

Warning: This method is deprecated, please use the stdlib validate_legacy function,
                    with Stdlib::Compat::Bool. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/cod
e/environments/production/modules/winlogbeat/manifests/init.pp", 60]:
   (at C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:28:in `deprecation')
Warning: This method is deprecated, please use the stdlib validate_legacy function,
                    with Stdlib::Compat::Hash. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/cod
e/environments/production/modules/winlogbeat/manifests/init.pp", 103]:
   (at C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:28:in `deprecation')
Warning: This method is deprecated, please use the stdlib validate_legacy function,
                    with Stdlib::Compat::String. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/c
ode/environments/production/modules/winlogbeat/manifests/init.pp", 104]:
   (at C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:28:in `deprecation')

The params have been assigned a type based on the validate_type function that was used before.

bastelfreak commented 6 years ago

Hi @f1ngerscr0ssed, thanks for the PR! Can you please take a look at the travis issues and the inline comments I made?

vox-pupuli-tasks[bot] commented 4 years ago

Dear @f1ngerscr0ssed, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @f1ngerscr0ssed, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @f1ngerscr0ssed, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @f1ngerscr0ssed, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

lucasmaurice commented 1 year ago

Hi there! Is it ok if I take care of this issue, as I need the module to be updated ? And apparently @f1ngerscr0ssed will not continue on this one :D

smortex commented 1 year ago

Hi there! Is it ok if I take care of this issue, as I need the module to be updated ?

Of course! Feel free to open a new PR, I guess that you can add Fixes #24 to it's description that way this PR will be cloned when your PR is merged!

Thank you!

zilchms commented 9 months ago

superseded by #68 Thanks for your contributions!

voxpupuli / puppet-winlogbeat

Replace validate deprecated functions with data types #24

Pull Request (PR) description