search

voxpupuli / puppet-yum

Puppet module for Yum
https://forge.puppet.com/puppet/yum
MIT License
16 stars 101 forks source link

Puppet 6 issue and knockout_prefix problem #121

Closed avidspartan1 closed 5 years ago

avidspartan1 commented 6 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

jocelynthode commented 5 years ago

I was able to bypass that when prefixing in my hiera file the yum::gpgkeys with "---" just above.

Do we have an ETA on this PR being merged and a new version release @bastelfreak ?

bastelfreak commented 5 years ago

Hi, thanks for the PR.I'm not sure if this a breaking change or not. Could you explain a bit in which setup the old code break? Could you provide this as an acceptance test?

avidspartan1 commented 5 years ago

The delete_undef_values code broke in an earlier version of Puppet 6--it looks like it was addressed in a later release. However, the knockout_prefix issue is still a problem. I'll try to find some time to update the PR.

a-zen commented 5 years ago

I'm facing the same issue by simply using the yum module without any configuration on a clean centos7 system. The patch from @bastelfreak fixes the issue.

TJM commented 5 years ago

I am glad you have this fixed already, cause I was just about to dig into this one, and it was making me dizzy already. :)

larsnaesbye commented 5 years ago

Great! :-) Shouldn't this warrant a release? I don't mind patching locally, but it'd be easier to upgrade the module since Puppet 6 still acts up with 3.1.1.

dgoldsmith commented 5 years ago

PR #121 may have been merged on 3/16/2019 but no new release tags have been published since then. Version 3.1.1 is still the latest tagged release and it does not include the gpgkeys knockout prefix fix.

bastelfreak commented 5 years ago

I'm doing a new release at https://github.com/voxpupuli/puppet-yum/pull/134

dgoldsmith commented 5 years ago

Thanks, that fixed it.

David Goldsmith

From: Tim Meusel notifications@github.com Reply-To: voxpupuli/puppet-yum reply@reply.github.com Date: Tuesday, May 7, 2019 at 2:48 PM To: voxpupuli/puppet-yum puppet-yum@noreply.github.com Cc: David Goldsmith DGoldsmith@sans.org, Comment comment@noreply.github.com Subject: Re: [voxpupuli/puppet-yum] Puppet 6 issue and knockout_prefix problem (#121)

I'm doing a new release at #134https://github.com/voxpupuli/puppet-yum/pull/134

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/voxpupuli/puppet-yum/pull/121#issuecomment-490209850, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABT6XGGVPJ734Q6RBAP5GMDPUHFHLANCNFSM4FYJ7PQA.