instantiate yumrepo & yum::config directly

voxpupuli / puppet-yum

Puppet module for Yum

https://forge.puppet.com/puppet/yum

MIT License

16 stars 101 forks source link

instantiate yumrepo & yum::config directly #148

Closed igalic closed 4 years ago

igalic commented 4 years ago

Pull Request (PR) description

Since we're not doing any dynamic creation of potentially unknown resources, we want to use yumrepo and yum::config directly, rather than going thru Resource

This Pull Request (PR) fixes the following issues

none; only my confusion when reading the code.

alexjfisher commented 4 years ago

@lamawithonel - let us know if we're accidentally breaking something! ;)

lamawithonel commented 4 years ago

I don't recall why I did that. I worked on a replacement yumrepo resource type for a short time, but ultimately scrapped it. It might have been a mix-up with another version to swap out the type. In any case, you're right, it's unneeded the way it is now.

lgtm :+1:

alexjfisher commented 4 years ago

@lamawithonel Many thanks for the feedback.