Closed mdechiaro closed 1 year ago
Dear @mdechiaro, thanks for the PR!
This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks
I reviewed the failed checks, and it appears they were caused by Docker rate-limiting. I pasted one of the them below.
https://travis-ci.org/github/voxpupuli/puppet-yum/jobs/766942869#L1318
Maybe rerun them, it's normally a problem.
It's a useful feature for sure.
Dear @mdechiaro, thanks for the PR!
This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
@mdechiaro Are you planning to revive this PR? I have a profile in my site module to enable versionlock from hiera and would like to see this feature merged.
@jhoblitt thanks for reaching out. Its been a long time since I looked at this module, however I can take a look and try to get it resolved in a few days. Also, if you have code ready to be pushed, then by all means do so and I'll close this one out.
@mdechiaro this PR looks reasonable to me. It just needs acceptance or unit tests.
?
Pull Request (PR) description
This change adds a new parameter, versionlock_options, to manage package versionlocks in Hiera.
This Pull Request (PR) fixes the following issues
Add new feature for supporting Hiera with versionlock configurations.