Closed josuemotte closed 1 year ago
Documentation (yaml) bugs aside, I am not sure what you are trying to accomplish here? This would run yum upgrade (or update), which I always thought were the same operation in yum[1], every puppet run. I know I wouldn't want that ;)
At a minimum, you might run it with unless => 'yum check-upgrade'
... but I still wouldn't want that to run every 30 minutes.
Tommy
[1] https://serverfault.com/questions/298146/yum-equivalent-to-apt-get-upgrade-vs-apt-get-dist-upgrade/298158#298158 - They are not the same, upgrade is the one you want, generally ;)
Hello,
Indeed this is why I put by the default value to false, in a case of using puppet in masterless mode then it's quite useful especially for mobile workstation which are not always connected in the office.
We thought to use something like yum-cron but it seems since those machines are not always up this solution seemed to be at least for the case of masterless the most appropriate.
Beside that I can remove the update part since as highlighted.
Josué
Hello @TJM ,
Do you want me to remove the yum update
part ?
Thank you, Josué
Honestly, it is not my module @josuemotte ;) ... so I can't make any decrees like that. I would probably stick with just upgrade if I wanted this feature. AS I said above, I don't want puppet running yum upgrade every 30 minutes, that seems dangerous at best. It is up to the maintainers, though ;)
Dear @josuemotte, thanks for the PR!
This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Pull Request (PR) description
Allow to perform in needed case
yum update
or/andyum upgrade
Way to use within hiera :