search

voxpupuli / puppet-yum

Puppet module for Yum
https://forge.puppet.com/puppet/yum
MIT License
16 stars 101 forks source link

Add support for AlmaLinux 8 #203

Closed tparkercbn closed 3 years ago

tparkercbn commented 3 years ago

Pull Request (PR) description

Added support for AlmaLinux 8

This Pull Request (PR) fixes the following issues

tparkercbn commented 3 years ago

Is anyone able to help me fix the tests? I'm not very familiar with Travis-CI

TheMeier commented 3 years ago

@tparkercbn can you please rebase that to latest master branch

tparkercbn commented 3 years ago

@tparkercbn can you please rebase that to latest master branch

Done I think! :)

Tom

tparkercbn commented 3 years ago

Leftover. Let me clean that up.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Tim Meusel @.> Sent: Wednesday, June 9, 2021 11:06:50 AM To: voxpupuli/puppet-yum @.> Cc: Tom Parker @.>; Mention @.> Subject: Re: [voxpupuli/puppet-yum] Added support for AlmaLinux 8 (#203)

CAUTION: This email originated from outside your organization. Exercise caution when opening attachments or on clicking links from unknown senders.

@bastelfreak commented on this pull request.

In metadata.jsonhttps://github.com/voxpupuli/puppet-yum/pull/203#discussion_r648507235:

@@ -70,6 +70,19 @@ "operatingsystemrelease": [ "2017" ]

  • },
  • {
  • "operatingsystem": "Fedora",

is that a leftover from the rebase or did you add Fedora on purpose?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/voxpupuli/puppet-yum/pull/203#pullrequestreview-679924989, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJYF5VYV4VQYZRJC3KACFTTR6NSVANCNFSM45IBGFCA.

tparkercbn commented 3 years ago

Fixed it now. Sorry :) I'm not great with Git.

bastelfreak commented 3 years ago

@tparkercbn can you please take a look at the failing tests?

tparkercbn commented 3 years ago

Is anyone able to help me fix the tests? I'm not very familiar with Travis-CI

@bastelfreak I had asked above if someone can help with them. I have no idea how Travis-CI works. I am contributing code that I need to use for my job to get the modules to work but right now I'm swamped and don't have time to learn Travis and I'm hoping that someone else who is more familiar with this can help me fix them up.

Tom

tparkercbn commented 3 years ago

I pushed a new commit that may help. I'm just not sure what the consequences are.

I set: # rubocop:disable RSpec/RepeatedExample anywhere there was a conflict.

tparkercbn commented 3 years ago

Looks like it worked!