search

voxpupuli / puppet-yum

Puppet module for Yum
https://forge.puppet.com/puppet/yum
MIT License
16 stars 99 forks source link

Use standard directory permissions #265

Closed smoeding closed 2 years ago

smoeding commented 2 years ago

Pull Request (PR) description

With a recent commit the module started to manage /etc/yum.repos.d. Unfortunately the non-standard directory mode 0644 is used.

This PR changes the directory mode to the more suitable 0755.

jcpunk commented 2 years ago

Shouldn't puppet be automatically adding +x to directories it can read? I thought the recurse option would push permissions onto contained files - thus making the .repo files +x (I could be wrong here).

jcpunk commented 2 years ago

https://puppet.com/docs/puppet/7/types/file.html#file-attribute-mode

smoeding commented 2 years ago

Well, looks like it really works. When I tested the module update I had a duplicate resource error because I managed the repo directory locally until now. I just looked at the code and didn't test any more. Sorry about that!

The Puppet language otherwise tries to be very expressive about the state of a resource, so I'm not convinced that it is good style.