search

voxpupuli / puppet-zabbix

Puppet module for creating and maintaining zabbix components with puppet.
https://forge.puppet.com/puppet/zabbix
Apache License 2.0
80 stars 229 forks source link

Adds 5.x in the version check for which schema path to use #737

Closed jameskirsop closed 3 years ago

jameskirsop commented 3 years ago

Helps address #689 by allowing for the correct database schema path to be used when doing the initial installation for a 5.0 install.

Also just realised that this is a dupe of both #715 and #694 and we're in the same holding pattern now because of the acceptance tests. Maybe a maintainer (@bastelfreak?) can assist in pointing @aclarkee, @stanhva and myself in the right direction?

bastelfreak commented 3 years ago

hey! so the acceptance tests are in https://github.com/voxpupuli/puppet-zabbix/tree/master/spec/acceptance. that's basically puppet code that gets executed in a docker container. some of the tests install the zabbix server in a specific version. It would be good if at least one of them gets extended (simply copy and paste the puppet code + tests and append it). https://github.com/voxpupuli/puppet-zabbix/blob/master/spec/acceptance/server_spec.rb in particular would be a good candidate. it installs a minimal zabbix server and afterwards checks if the service + database is running.