search

voxpupuli / puppet-zabbix

Puppet module for creating and maintaining zabbix components with puppet.
https://forge.puppet.com/puppet/zabbix
Apache License 2.0
80 stars 228 forks source link

Respect manage_repo for RedHat family #801

Closed fraenki closed 2 years ago

fraenki commented 2 years ago

Pull Request (PR) description

In https://github.com/voxpupuli/puppet-zabbix/pull/736 the CentOS SCL repo was added by installing centos-release-scl. However, this breaks repository management for folks that have $manage_repo set to false.

This PR ensure that the SCL repo package is only installed when $manage_repo is set to true.

Another approach would be to move the installation of the centos-release-scl package from zabbix::web to zabbix::repo. Let me know what you think.

This Pull Request (PR) fixes the following issues

Having two modules trying to manage the SCL repo leads to all kinds of issues, i.e. duplicate declarations.

root-expert commented 2 years ago

To be honest that piece of code was probably belonging to zabbix::repo as you said but was added to the wrong place.

If you think you can move it and update the specs please do it, else I'm happy to merge this PR.

fraenki commented 2 years ago

If you think you can move it and update the specs please do it

@root-expert I've moved it to zabbix::repo. The downside of this is that the SCL repo package also gets installed when zabbix::web is not being used.

root-expert commented 2 years ago

If you think you can move it and update the specs please do it

@root-expert I've moved it to zabbix::repo. The downside of this is that the SCL repo package also gets installed when zabbix::web is not being used.

That seems okay for me