Fix #817 - startup_script fails for windows

voxpupuli / puppet-zabbix

Puppet module for creating and maintaining zabbix components with puppet.

https://forge.puppet.com/puppet/zabbix

Apache License 2.0

80 stars 228 forks source link

Fix #817 - startup_script fails for windows #818

Closed logicminds closed 2 years ago

logicminds commented 2 years ago

Previously the windows agent puppet code did not handle windows properly and failed the catalog build due to a case sensitive issue. This fixes that by downcase the agent name first.

bastelfreak commented 2 years ago

thanks for the PR. on which windows versions did you test / are they missing in https://github.com/voxpupuli/puppet-zabbix/blob/master/metadata.json#L143-L149 ?

logicminds commented 2 years ago

Yea this was on 2019, but it is a code issue and not a platform one. Anyways 2019 work great so I think adding 2019 is applicable. Do you want me to update the metadata to include that?

bastelfreak commented 2 years ago

yes, please add it :) (and if you've really much spare time and could submit windows facts to https://github.com/voxpupuli/facterdb/pulls I will add you to my chocolate-giftlist-for-future-conferences)

bastelfreak commented 2 years ago

I will fix the arch linux failures in another PR