voxpupuli / puppet-zabbix

Puppet module for creating and maintaining zabbix components with puppet.
https://forge.puppet.com/puppet/zabbix
Apache License 2.0
79 stars 228 forks source link

Old template name hard coded #846

Open Fabian1976 opened 1 year ago

Fabian1976 commented 1 year ago

When you deploy a new Zabbix instance en manage_resources is set to true, you lose idempotency and every run this is displayed:

Notice: /Stage[main]/Zabbix::Resources::Web/Zabbix_userparameters[<FQDN_PROXY>_<NAME_PROXY_Zabbix_Proxy]/ensure: created

This is because the template is named Zabbix Proxy and in the code the old template name is hard-coded: https://github.com/voxpupuli/puppet-zabbix/blob/a122643b8c3e60685cc8577ce7f04c5e0360d6dd/manifests/proxy.pp#L349

There also seems to be a parameter zbx_templates in the proxy.pp class which is not used.

Is this being fixed? Or do you wan't a PR?