search

voxpupuli / puppet-zabbix

Puppet module for creating and maintaining zabbix components with puppet.
https://forge.puppet.com/puppet/zabbix
Apache License 2.0
79 stars 228 forks source link

Certificate authentication in zabbix_host resource #848

Closed teluq-pbrideau closed 1 year ago

teluq-pbrideau commented 1 year ago

Pull Request (PR) description

inspired from #700

I need to authenticate with certificate in my infrastructure, this PR allow to push the configuration to the zabbix server via «storeconfigs»

As stated in #700, there is an issue with setting the PSK through the API as PSK values are write only since zabbix 5.4. So I didn’t bother to dig deeper on this part, as I don’t require it in my infrastructure.

This Pull Request (PR) fixes the following issues

teluq-pbrideau commented 1 year ago

Well… checks failed in a file I had not modified (web.pp), do you want me to fix this test anyway?

manifests/web.pp:410:manifest_whitespace_opening_brace_before:ERROR:there should be a single space before an opening brace
manifests/web.pp:416:manifest_whitespace_opening_brace_before:ERROR:there should be a single space before an opening brace
manifests/web.pp:420:manifest_whitespace_opening_brace_before:ERROR:there should be a single space before an opening brace
manifests/web.pp:424:manifest_whitespace_opening_brace_before:ERROR:there should be a single space before an opening brace
manifests/web.pp:428:manifest_whitespace_opening_brace_before:ERROR:there should be a single space before an opening brace
teluq-pbrideau commented 1 year ago

What do you recommend for me to test my changes here? 1- Should I wait for #850 to be merged and rebase this branch from master? 2- Or is it good practice to merge from another branch directly on this PR?

teluq-pbrideau commented 1 year ago

Tests for CentOS 7 still broken, I’ll try to rebase my fixes and make the test run again