search

voxpupuli / puppet-zabbix

Puppet module for creating and maintaining zabbix components with puppet.
https://forge.puppet.com/puppet/zabbix
Apache License 2.0
79 stars 228 forks source link

use provided database port in pgpass #851

Closed teluq-pbrideau closed 1 year ago

teluq-pbrideau commented 1 year ago

Pull Request (PR) description

When configuring a postgresql database that is not running on port 5432, the .pgpass is not correctly configured.

Then, the exec { 'zabbix_server_create.sql':} does not succeed as the server could not connect to the database.

teluq-pbrideau commented 1 year ago

I’ve squashed my commits to be cleaner, feel free to ask f you want me to squash it further

bastelfreak commented 1 year ago

na it is fine the way it is :) lets see what CI says

teluq-pbrideau commented 1 year ago

Well, the CI will surely crash because of renaming of template as i said in https://github.com/voxpupuli/puppet-zabbix/pull/854#issuecomment-1332360269, so I’m sure I won’t have any green tick right now :smile:

smortex commented 1 year ago

@teluq-pbrideau so, if we rebase this one on top of master it should pass :grinning: ?

From your working directory:

git fetch origin       # Download the latest code we have here
git rebase origin/master # Move your commits on top of the main branch
git push -f            # Send the changes (-f is required because we re-wrote history)