voxpupuli / puppet-zabbix

Puppet module for creating and maintaining zabbix components with puppet.
https://forge.puppet.com/puppet/zabbix
Apache License 2.0
79 stars 228 forks source link

Module forces v5 repos when running on a non windows OS #852

Open Ph0B1uS opened 1 year ago

Ph0B1uS commented 1 year ago

https://github.com/voxpupuli/puppet-zabbix/blob/a122643b8c3e60685cc8577ce7f04c5e0360d6dd/manifests/params.pp#L128-L132

This is the offending line which makes it impossible to install any version above 5.X as the repo is managed by the module and only installs v5 rather than adapting to zabbix_version

root-expert commented 1 year ago

Hello @Ph0B1uS, if you override zabbix_version it will install the specified version, the code above is just the default value. Can you post some puppet code to understand better your problem?

ekohl commented 8 months ago

As @root-expert said, those are just the defaults and you can choose another version. Closing due to inactivity, but feel free to reopen if it's still an issue.

Ph0B1uS commented 8 months ago

It will install the specified version of the zabbix-package but it doesn't seem to affect what repo is set up. It's fine to specify v 6.4.2 but since the repo installed is 5.x by default then all that will do is result in a failed puppet run since there is no zabbix v 6.4.2 in the 5.x repo.

ekohl commented 8 months ago

Perhaps you can give some examples of how you're using the module.

Valantin commented 4 months ago

@Ph0B1uS can you add more detailed information? Like your OS version and a manifest example of how you use this module?