voxpupuli / puppet-zabbix

Puppet module for creating and maintaining zabbix components with puppet.
https://forge.puppet.com/puppet/zabbix
Apache License 2.0
79 stars 228 forks source link

Bootstrap agent2 support (continued) - Waiting for postgresql fix #868

Closed Phil-Friderici closed 8 months ago

Phil-Friderici commented 1 year ago

In this PR I try to continue the work of fe80 (and others) in PR824.

Pull Request (PR) description

This Pr bootstrap a support for zabbix-agent2

It's possible to use agent2 with this configration:

      'agent_configfile_path' => '/etc/zabbix/zabbix_agent2.conf',
      'include_dir'           => '/etc/zabbix/zabbix_agent2.d',
      'pidfile'               => '/var/run/zabbix/zabbix_agentd2.pid',
      'servicename'           => 'zabbix-agent2',
      'zabbix_package_agent'  => 'zabbix-agent2',
      'binary_location'       => '/usr/sbin/zabbix_agent2',

I actually not test with windows kernel.

This Pull Request (PR) fixes the following issues

Fixes #692

Phil-Friderici commented 1 year ago

Rebased against master.

Phil-Friderici commented 1 year ago

The spec tests all run fine when using puppetlabs/postgresql v7.5.0 instead. The latest version of postgresql introduced a bug that does fail on ArchLinux. I have create the issue#1408 with a description of the problem and @smortex was so kind (merci beaucoup!) to create PR#1410 to get it fixed.

Currently they are working on a fix and I am looking forward for a new fixed release of postgresql that should work well with this code.

Regarding the failing of the acceptance tests, I am not sure what is needed to fix them. Any help would be very appreciated.

Phil-Friderici commented 8 months ago

Closed in favour of #914