search

voxpupuli / puppet-zabbix

Puppet module for creating and maintaining zabbix components with puppet.
https://forge.puppet.com/puppet/zabbix
Apache License 2.0
79 stars 229 forks source link

Add support for ODBC pollers in Zabbix >= 6.0 #881

Closed fraenki closed 7 months ago

fraenki commented 11 months ago

Pull Request (PR) description

This PR adds support for the StartODBCPollers configuration parameter, that was introduced in Zabbix 6.0.

This Pull Request (PR) fixes the following issues

This parameter was already discussed in https://github.com/voxpupuli/puppet-zabbix/issues/814#issuecomment-1042347988, but a PR was never submitted, AFAICT.

fraenki commented 11 months ago

The test failure does not seem to be related to this PR.

smortex commented 11 months ago

REFERENCE.md is outdated

Please update REFERENCE.md with

$ bundle exec rake strings:generate:reference

Add it to the PR and CI should continue.

fraenki commented 11 months ago

Please update REFERENCE.md with

Done.

root-expert commented 9 months ago

@fraenki Please consider adding basic tests for the new parameter both for the proxy and the server :smile:

fraenki commented 8 months ago

@root-expert Rebased against current master and added basic tests.

(Side note: This module runs most tests with zabbix_version=5.0 and zabbix_version=6.0 is not supported for the server class on all operating systems. As a result the tests I've added aren't perfect. But once all tests run with zabbix_version=6.0 everything should be fine.)

fraenki commented 8 months ago

@root-expert, all suggested changes applied, thanks. :)