voxpupuli / puppet-zabbix

Puppet module for creating and maintaining zabbix components with puppet.
https://forge.puppet.com/puppet/zabbix
Apache License 2.0
79 stars 229 forks source link

Bootstrap agent2 support (rebased) #914

Closed Phil-Friderici closed 4 months ago

Phil-Friderici commented 7 months ago

In this PR I try to continue the work of fe80 (and others) in PR824.

Pull Request (PR) description

This Pr bootstrap a support for zabbix-agent2

It's possible to use agent2 with this configration:

      'agent_configfile_path' => '/etc/zabbix/zabbix_agent2.conf',
      'include_dir'           => '/etc/zabbix/zabbix_agent2.d',
      'pidfile'               => '/var/run/zabbix/zabbix_agentd2.pid',
      'servicename'           => 'zabbix-agent2',
      'zabbix_package_agent'  => 'zabbix-agent2',
      'binary_location'       => '/usr/sbin/zabbix_agent2',

I actually not test with windows kernel.

This Pull Request (PR) fixes the following issues

Fixes #692

Clebam commented 6 months ago

Hi @Phil-Friderici,

just to let you know that to handle windows installation from msi I needed to add this to the $agent2 boolean $agent2 = $zabbix_package_agent in ['zabbix-agent2', 'Zabbix Agent 2 (64-bit)']

You could also make it available in the params maybe

Thanks

Valantin commented 4 months ago

what is missing to merge it?

Valantin commented 4 months ago

@Phil-Friderici can you rebase the PR? a fix for new acceptance was merged

Phil-Friderici commented 4 months ago

@Valantin Thanks for rebasing the PR. You were faster than me ;) Hope this time it will get merged.

Closing this PR in favour of #929